Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update StagingDeployCash for manual cherry-picks #4798

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Update StagingDeployCash for manual cherry-picks #4798

merged 1 commit into from
Aug 24, 2021

Conversation

roryabraham
Copy link
Contributor

Details

If the cherryPick.yml workflow was run manually (i.e: by a user other than OSBotify), then we need to update the deploy checklist to include the newly deployed PR.

Fixed Issues

$ #4379

Tests

  1. Merge this PR with the deploy checklist locked.
  2. Manually CP this PR.
  3. Verify that, once the CP workflow completes, the checklist is updated to include this PR.

QA Steps

None.

@roryabraham roryabraham requested a review from a team August 24, 2021 04:01
@roryabraham roryabraham self-assigned this Aug 24, 2021
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team August 24, 2021 04:02
nkuoch
nkuoch approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@nkuoch nkuoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Adding @tgolen as a final reviewer as he's more familiar with the process.

@nkuoch nkuoch requested a review from tgolen August 24, 2021 09:33
@tgolen tgolen merged commit e420c83 into main Aug 24, 2021
@tgolen tgolen deleted the Rory-AddCPsToDeployChecklist branch August 24, 2021 19:40
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 24, 2021
Closed
@roryabraham
Copy link
Contributor Author

Manually CPing this to test if it works!

@roryabraham
Copy link
Contributor Author

JK, it's already been added to the checklist. So I'll have to remember to test this with another PR.

@roryabraham
Copy link
Contributor Author

This did not work as expected. I forgot that the createOrUpdateStagingDeploy action relies on the new tag having been created in the runner. Will create a follow-up PR to fix.

@roryabraham
Copy link
Contributor Author

This failure was fortuitous, as it maybe led me to a revelation of how to fix a related bug that has been marring me for months now. In case you're curious....

But that means that the fix for this is maybe actually a bit greater in scope than a quick follow-up, so we should revert this. It's not actually breaking anything, just causing red herring CP workflow failures.

@roryabraham roryabraham mentioned this pull request Aug 25, 2021
Merged
@roryabraham
Copy link
Contributor Author

Revert PR is ready: #4815

@OSBotify OSBotify mentioned this pull request Aug 25, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgolen tgolen tgolen approved these changes

@nkuoch nkuoch nkuoch approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roryabraham @OSBotify @tgolen @nkuoch